Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TriangulizedMat([]) #2260

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Fix TriangulizedMat([]) #2260

merged 1 commit into from
Mar 12, 2018

Conversation

fingolfin
Copy link
Member

This PR ensures that TriangulizedMat([]) returns an empty list / matrix, instead of triggering an error.

This in turn fixes a regression in the modisom package in GAP 4.9 (compared to GAP 4.8 and before), see gap-packages/modisom#2

This change should be cherry-picked to stable-4.9

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements backport-to-4.9 labels Mar 11, 2018
@fingolfin fingolfin mentioned this pull request Mar 11, 2018
Closed
sebasguts
sebasguts approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a test for this, to not break it again?

@codecov
Copy link

codecov bot commented Mar 12, 2018 •
edited
Loading

Codecov Report

Merging #2260 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2260      +/-   ##
==========================================
+ Coverage   70.57%   70.57%   +<.01%     
==========================================
  Files         481      481              
  Lines      253236   253237       +1     
==========================================
+ Hits       178729   178731       +2     
+ Misses      74507    74506       -1
Impacted Files Coverage Δ
lib/matrix.gi 78% <100%> (+0.01%) ⬆️
src/io.c 61.42% <0%> (+0.08%) ⬆️

@fingolfin fingolfin merged commit 43525d8 into gap-system:master Mar 12, 2018
@fingolfin fingolfin deleted the mh/empty-TriangulizedMat branch March 12, 2018 15:17
@fingolfin fingolfin added this to the GAP 4.9.1 milestone Mar 12, 2018
@fingolfin
Copy link
Member Author

Backported to stable-4.9 via 189635d

@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasguts sebasguts sebasguts approved these changes

@olexandr-konovalov olexandr-konovalov Awaiting requested review from olexandr-konovalov

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @sebasguts