Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make break, continue, and return interruptible #2259

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Make break, continue, and return interruptible #2259

merged 1 commit into from
Mar 21, 2018

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Mar 10, 2018 •
edited
Loading

Fixes #2256

We may want to backport this to stable-4.9

I don't see a good way to add a test for this.

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Mar 10, 2018
@codecov
Copy link

codecov bot commented Mar 10, 2018 •
edited
Loading

Codecov Report

Merging #2259 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2259      +/-   ##
==========================================
- Coverage   70.57%   70.57%   -0.01%     
==========================================
  Files         481      481              
  Lines      253239   253239              
==========================================
- Hits       178734   178727       -7     
- Misses      74505    74512       +7
Impacted Files Coverage Δ
src/code.h 100% <ø> (ø) ⬆️
hpcgap/lib/hpc/queue.g 66.4% <0%> (-3.2%) ⬇️
hpcgap/lib/hpc/stdtasks.g 38.61% <0%> (-0.26%) ⬇️
src/funcs.c 78.27% <0%> (-0.14%) ⬇️
src/stats.c 85.57% <0%> (-0.14%) ⬇️

@fingolfin fingolfin requested a review from stevelinton March 20, 2018 13:20
stevelinton
stevelinton approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@stevelinton stevelinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and works as far as I can test.

@fingolfin fingolfin added this to the GAP 4.9.1 milestone Mar 21, 2018
@fingolfin fingolfin merged commit f26f6e3 into gap-system:master Mar 21, 2018
@fingolfin
Copy link
Member Author

fingolfin commented Mar 21, 2018 •
edited
Loading

Backported to stable-4.9 as ea1d381

@fingolfin fingolfin deleted the mh/interrupt-continue branch March 21, 2018 13:27
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevelinton stevelinton stevelinton approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @stevelinton