InstallImmediateMethod: make rank optional, tweak docs #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
kind: enhancement
Clarify in the InstallImmediateMethod documentation that <info> is an optional argument. Moreover, make the <rank> optional, too (if omitted, 0 is used as default value).
fingolfin
force-pushed
the
mh/InstallImmediateMethod
branch
from
1f63a56 to
ebd6df2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
==========================================
+ Coverage 70.34% 70.34% +<.01%
==========================================
Files 481 481
Lines 253181 253212 +31
==========================================
+ Hits 178091 178127 +36
+ Misses 75090 75085 -5
|
stevelinton
approved these changes
Mar 21, 2018
fingolfin
added
the
release notes: to be added
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
<rank>argument toInstallImmediateMethodoptional (if omitted, 0 is used as default value).