Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: use LcmInt in order computations, fix GC bugs #2154

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

fingolfin
Copy link
Member

The order computation for permutations, partial permutations and
transformations now uses LcmInt(). Also, fixed a garbage collection related
bug in each: a GC could invalidate pointers to a temporary object

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: kernel labels Feb 4, 2018
@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #2154 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
+ Coverage   69.34%   69.38%   +0.03%     
==========================================
  Files         484      485       +1     
  Lines      253917   255428    +1511     
==========================================
+ Hits       176085   177225    +1140     
- Misses      77832    78203     +371
Impacted Files Coverage Δ
src/integer.h 100% <ø> (ø) ⬆️
src/pperm.c 83.66% <100%> (+0.05%) ⬆️
src/permutat.c 78.02% <100%> (-0.03%) ⬇️
src/trans.c 98.72% <100%> (-0.01%) ⬇️
src/hpc/guards.h 80.55% <0%> (-11.45%) ⬇️
src/debug.c 26.92% <0%> (-9.92%) ⬇️
src/hpc/thread.c 51.48% <0%> (-4.23%) ⬇️
src/hpc/aobjects.c 67.4% <0%> (-4.22%) ⬇️
hpcgap/lib/hpc/queue.g 66.4% <0%> (-3.2%) ⬇️
src/hpc/aobjects.h 84.61% <0%> (-2.89%) ⬇️
... and 39 more

The order computation for permutations, partial permutations and
transformations now uses LcmInt(). Also, fixed a garbage collection related
bug in each: a GC could invalidate pointers to a temporary object
Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch...

@fingolfin fingolfin merged commit ea95324 into gap-system:master Feb 5, 2018
@fingolfin fingolfin deleted the mh/LcmInt-for-order branch February 5, 2018 15:30
@fingolfin fingolfin added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants