-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method for PositionsProperty on non-dense Lists #2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
+ Coverage 66% 66% +<.01%
==========================================
Files 898 898
Lines 273268 273275 +7
Branches 12745 12745
==========================================
+ Hits 180378 180383 +5
+ Misses 90071 90069 -2
- Partials 2819 2823 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (but bonus points if you also add a test case for this)
d5f11f1
to
38b552a
Compare
@fingolfin Did so, do I get my bonus points ;)? |
@sebasguts sure, and a pony and a rainbow! |
@sebasguts bonus points are awarded only if you will help to fix (50% points if at least identify the reason) of the failure of your newly submitted test when all available packages are loaded: https://travis-ci.org/gap-system/gap-docker-master-testsuite/jobs/316407774 |
Cause QPA has an installation of the function that is installed for arbitrary lists, but does not work on lists with holes. I will provide them a patch. |
That patch would consist of them removing their Also, unless they release a fixed version quickly, we could raise the rank of our |
Yep, did a PR to remove the functions from QPA. Update(AK): it is gap-packages/qpa#8 |
No description provided.