Remove profiling limit on files with <= 2^16 lines #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new limit is 2^31, which should be sufficient for everybody (TM).
fingolfin
added
kind: enhancement
|
@ChrisJefferson any thoughts on this? |
|
My concern is that I'm not completely sure when we get a string, and when we get an int, and exactly how that effects various things. Profiling will never output anything about lines where we store a string instead of an ID. When does that happen, and should it worry us? |
|
It will happen if and only if it happened before. Which I think is never for actual GAP functions (and always for non-GAP functions, just like before). We could add a GAP_ASSERT to verify that. |
ChrisJefferson
approved these changes
Nov 20, 2017
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new limit is 2^31, which should be sufficient for everybody (TM).
It exploits the fact that all statements in a
T_BODYcome from the same file, and that file is being recored in theT_BODYbag anyway.Previously, the filename was stored as a string object in the
T_BODY. This still is supported (and used by some code), but for regular GAP functions, we now instead store an immediate integer indexing into thefilecache. This is so that profiling code does not have to be modified to heavily.