Formatted OutStreams #1816
Open
Formatted OutStreams #1816
+210
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These take an output stream, wrap it, and take care of indentation, and prefixing respectively.
|
So... is this supposed to be reviewed? Or do you just want to discuss the design? I am not sure what the final verdict on your slack discussion was as to the "default assumption" for a PR without any labels... |
fingolfin
reviewed
Oct 27, 2017
| @@ -31,6 +31,8 @@ | |||
| <#Include Label="IsOutputStream"> | |||
| <#Include Label="IsOutputTextStream"> | |||
| <#Include Label="IsOutputTextNone"> | |||
| <#Include Label="IsOutputStreamFormatter"> | |||
| <#Include Label="IsOutputStreamPrefixer"> | |||
There was a problem hiding this comment.
No GAPDoc chunks with these names exist, hence the makemanuals tests fail.
markuspf
added
do not merge
fingolfin
added
kind: discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a resurrection of #895, adding two output stream wrappers:
OutputStreamFormatterwraps an output stream and has internal state for indentation levels, and interprets'\<' and '\>' for indent and dedent.OutputStreamPrefixerwraps an output stream and prefixes every line with a prefix string.