Slightly extend MinimalGeneratingSet
for groups
#1755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
MinimalGeneratingSet
only supports soluble groups. Cyclic groups are soluble, and so a group that is not soluble requires at least two generators. Therefore, inMinimalGeneratingSet
, we can add a special case for groups that aren't soluable but already a generating set of size two.So this behaviour:
now becomes:
I'm wondering, do people think this is worth doing? And if so, have I gone about it the right way?