fixed an error in the default method for PositionNot #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
approved these changes
Sep 6, 2017
|
This seems to be breaking |
fingolfin
previously requested changes
Sep 6, 2017
lib/kernel.g
Outdated
| @@ -168,7 +168,7 @@ POSITION_NOT := function( arg ) | |||
| return i; | |||
| fi; | |||
| od; | |||
| return LENGTH(arg[1]) + 1; | |||
| return arg[3] + 1; | |||
There was a problem hiding this comment.
This is not quite correct: Think about arg[3] being 0 (in fact, PositionNot(list,x) is defined as PositionNot(list,x,0).
So instead of changing this line, you could insert this before line 166:
if arg[3]+1 > LENGTH(arg[1]) then
return arg[3] + 1;
fi;
Codecov Report
@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
+ Coverage 64.42% 64.42% +<.01%
==========================================
Files 1002 1002
Lines 326709 326712 +3
Branches 13197 13218 +21
==========================================
+ Hits 210477 210486 +9
+ Misses 113363 113357 -6
Partials 2869 2869
|
(and PositionNonZero), in the case that the given 'from' value is larger than the length of the list
ThomasBreuer
force-pushed
the
TB_avoid_PositionNot
branch
from
381f1c3
to
adeb73c
Compare
|
just fixed the fix, thanks for the hints |
fingolfin
reviewed
Sep 7, 2017
olexandr-konovalov
added
the
gapdays2017-fall
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed an error in the default method for PositionNot (and PositionNonZero),
in the case that the given 'from' value is larger than the length of the list