Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel functions for directly accessing entries of GF2/8bit compressed matrices #1585

Merged
merged 2 commits into from
Aug 17, 2017

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Aug 15, 2017

These changes are part of PR #1427, but are independent from those.

@codecov
Copy link

codecov bot commented Aug 15, 2017

Codecov Report

Merging #1585 into master will decrease coverage by 0.01%.
The diff coverage is 23.25%.

@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
- Coverage   63.99%   63.98%   -0.02%     
==========================================
  Files         995      995              
  Lines      325380   325454      +74     
  Branches    13019    13042      +23     
==========================================
+ Hits       208226   208227       +1     
- Misses     114357   114420      +63     
- Partials     2797     2807      +10
Impacted Files Coverage Δ
hpcgap/lib/vecmat.gi 64.87% <ø> (-0.01%) ⬇️
lib/vec8bit.gi 49.14% <ø> (-0.01%) ⬇️
lib/vecmat.gi 67.42% <ø> (ø) ⬆️
hpcgap/lib/vec8bit.gi 48.25% <ø> (-0.01%) ⬇️
lib/mat8bit.gi 65.83% <ø> (-0.09%) ⬇️
hpcgap/lib/mat8bit.gi 59.4% <ø> (-0.11%) ⬇️
src/vecgf2.c 55.73% <21.73%> (-0.83%) ⬇️
src/vec8bit.c 71.38% <25%> (-0.71%) ⬇️
src/permutat.c 74.34% <0%> (-1.27%) ⬇️
lib/grpmat.gi 67.91% <0%> (-0.56%) ⬇️
... and 9 more

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Aug 16, 2017
These allow efficient access to entries of compressed 8bit matrices
These allow efficient access to entries of compressed GF2 matrices
@fingolfin fingolfin merged commit 323141e into gap-system:master Aug 17, 2017
@fingolfin fingolfin deleted the mh/MatElm branch August 21, 2017 14:02
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 20, 2018
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants