Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LEN_POSOBJ_Handler for atomic positional objects #1414

Merged

Conversation

fingolfin
Copy link
Member

Also add a test for this.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: HPC-GAP Issues and PRs related to HPC-GAP topic: tests issues or PRs related to tests labels Jun 12, 2017
@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #1414 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   63.42%   63.43%   +<.01%     
==========================================
  Files        1011     1011              
  Lines      339073   339078       +5     
  Branches    13761    13752       -9     
==========================================
+ Hits       215068   215104      +36     
+ Misses     120961   120925      -36     
- Partials     3044     3049       +5
Impacted Files Coverage Δ
src/objects.c 76.41% <100%> (+0.65%) ⬆️
src/objects.h 80% <0%> (-0.49%) ⬇️
src/hpc/thread.c 47.14% <0%> (-0.2%) ⬇️
src/listfunc.c 76.77% <0%> (-0.18%) ⬇️
src/funcs.c 63.12% <0%> (-0.15%) ⬇️
hpcgap/src/stats.c 73.16% <0%> (-0.14%) ⬇️
src/vec8bit.c 72.31% <0%> (+0.03%) ⬆️
src/intfuncs.c 90.98% <0%> (+0.11%) ⬆️
hpcgap/src/plist.c 82.94% <0%> (+0.16%) ⬆️
src/hpc/threadapi.c 32.51% <0%> (+0.19%) ⬆️
... and 4 more

@fingolfin fingolfin force-pushed the mh/fix-atomic-LEN_POSOBJ branch from 5a657df to e8dbf93 Compare June 14, 2017 08:51
@ChrisJefferson ChrisJefferson merged commit 8155711 into gap-system:master Jun 14, 2017
@ChrisJefferson ChrisJefferson deleted the mh/fix-atomic-LEN_POSOBJ branch June 14, 2017 20:06
@ChrisJefferson ChrisJefferson restored the mh/fix-atomic-LEN_POSOBJ branch June 14, 2017 20:07
@fingolfin fingolfin deleted the mh/fix-atomic-LEN_POSOBJ branch June 16, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them topic: HPC-GAP Issues and PRs related to HPC-GAP topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants