etc/ci.sh: don't run tests on HPC-GAP #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of them currently hang, likely due to incomplete or broken library syncing. Since a lot of test files are affected, we skip the tests completely for now. Of course this should eventually be resolved by fixing the tests resp. the underlying bugs.
fingolfin
added
topic: HPC-GAP
Codecov Report
@@ Coverage Diff @@
## master #1227 +/- ##
==========================================
- Coverage 62.2% 59.27% -2.93%
==========================================
Files 882 935 +53
Lines 254141 293258 +39117
Branches 11949 18329 +6380
==========================================
+ Hits 158080 173819 +15739
- Misses 93260 115159 +21899
- Partials 2801 4280 +1479
Continue to review full report at Codecov.
|
|
I agree. Need to find out why hpc-gap is hanging (I think break loop) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of them currently hang, likely due to incomplete or broken
library syncing. Since a lot of test files are affected, we skip the
tests completely for now. Of course this should eventually be resolved
by fixing the tests resp. the underlying bugs.
This PR is an alternative to PR #1225 -- there are at least half a dozen .tst files with hangs in them (I did not investigate fully), so IMHO it doesn't make sense to try to find them all individually. Instead, we should work on the hangs separately, then once they are fixed, re-enable tests.