Check manual examples for all chapters even if one fails

[olexandr-konovalov]

Closes #1138

[olexandr-konovalov]

At the moment, PR #1135 is good to check this after it will be merged.

[codecov]

Codecov Report

Merging #1183 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1183   +/-   ##
=======================================
  Coverage    68.4%    68.4%           
=======================================
  Files         435      435           
  Lines      230677   230677           
=======================================
  Hits       157797   157797           
  Misses      72880    72880

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8a851...8cd17b5. Read the comment docs.

[olexandr-konovalov]

This PR has been tested with some artificial failures (two broken examples in two chapters) and in this case it worked as intended. It should be ready to merge as soon as the current CI tests will finish.

[olexandr-konovalov]

Puzzling where the -0.02% reduction of coverage comes from...

[fingolfin]

A simpler way to implement this (which possibly avoids the need of creating TestManualChapter), using the || operator:

bin/gap.sh -q -L testmanuals.wsp --cover $COVDIR/$(basename $ch).coverage <<GAPInput || TESTMANUALSPASS=no
...

Or of course also

echo "TestManualChapter(\"$1\"); QUIT_GAP(0);" | bin/gap.sh ... || TESTMANUALSPASS=no

[olexandr-konovalov]

@fingolfin Thanks for the tip - I've updated the PR and run CI tests twice - with and without errors. This is ready for merge now.

Also, now it shows zero coverage changes, as expected.