Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IsomorphismReesZeroMatrixSemigroup #1038

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

james-d-mitchell
Copy link
Contributor

@james-d-mitchell james-d-mitchell commented Dec 23, 2016

Please make sure that this pull request:

  • is submitted to the correct branch (the stable branch is only for bugfixes)
  • contains an accurate description of changes for the release notes below
  • provides new tests or relies on existing ones
  • correctly refers to other issues and related pull requests

Tick all what applies to this pull request

  • Adds new features
  • Improves and extends functionality
  • Fixes bugs that could lead to crashes
  • Fixes bugs that could lead to incorrect results
  • Fixes bugs that could lead to break loops

Write below the description of changes (for the release notes)

For a finite 0-simple semigroup, previously the isomorphism returned by IsomorphismReesZeroMatrixSemigroup was not defined on the zero of its domain or range.

For a finite 0-simple semigroup, previously the returned isomorphism was
not defined on the zero of its domain.
@codecov-io
Copy link

Current coverage is 49.56% (diff: 37.50%)

Merging #1038 into master will increase coverage by <.01%

@@             master      #1038   diff @@
==========================================
  Files           424        424          
  Lines        223277     223287    +10   
  Methods        3430       3430          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         110656     110683    +27   
+ Misses       112621     112604    -17   
  Partials          0          0          

Powered by Codecov. Last update 4ff9b38...b947738

@fingolfin fingolfin merged commit 4620502 into gap-system:master Jan 3, 2017
@fingolfin
Copy link
Member

Thanks!

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants