Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsys: stop installing ${includedir}/gap/src once no package needs it anymore #5361

Closed
4 tasks done
fingolfin opened this issue Feb 3, 2023 · 4 comments · Fixed by #5435
Closed
4 tasks done

buildsys: stop installing ${includedir}/gap/src once no package needs it anymore #5361

fingolfin opened this issue Feb 3, 2023 · 4 comments · Fixed by #5435
Assignees
@fingolfin
Labels
topic: build system topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Milestone
GAP 4.13.0

Comments

@fingolfin
Copy link
Member

fingolfin commented Feb 3, 2023 •
edited
Loading

Basically we need this while there are still distributed packages which use #include "src/compiled.h" or similar

As I write this, the following packages still do this:

  1. caratinterface -- resolved in version 2.3.5
  2. digraphs -- resolved in version 1.6.2
  3. EDIM -- resolved in version 1.3.7
  4. IO -- resolved in 4.8.1
@fingolfin fingolfin added topic: build system topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) labels Feb 3, 2023
@fingolfin fingolfin added this to the GAP 4.13.0 milestone Feb 3, 2023
@fingolfin fingolfin self-assigned this Feb 3, 2023
@james-d-mitchell
Copy link
Contributor

@fingolfin happy to fix this, what is the fix exactly?

@fingolfin
Copy link
Member Author

@james-d-mitchell digraphs/Digraphs#571

@fingolfin fingolfin mentioned this issue Mar 27, 2023
Closed
@fingolfin fingolfin mentioned this issue Apr 4, 2023
Closed
@fingolfin
Copy link
Member Author

Merci @james-d-mitchell

@fingolfin fingolfin reopened this Apr 5, 2023
@fingolfin
Copy link
Member Author

Reopening as the prerequisites are done but not the actual change to make install

@fingolfin fingolfin mentioned this issue Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fingolfin fingolfin

Labels
topic: build system topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Milestone
GAP 4.13.0
Development

Successfully merging a pull request may close this issue.

Stop installing headers into ${includedir}/gap/src fingolfin/gap
2 participants
@fingolfin @james-d-mitchell