Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase tests coverage for the GAP compiler #2249

Open
fingolfin opened this issue Mar 7, 2018 · 1 comment
Open

Increase tests coverage for the GAP compiler #2249

fingolfin opened this issue Mar 7, 2018 · 1 comment
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests

Comments

@fingolfin
Copy link
Member

fingolfin commented Mar 7, 2018 •
edited by DominikBernhardt
Loading

Right now, our tests for the GAP compiler are very limited (mostly our coverage comes from running make docomp). It would be good to extend that; in the past, untested compiler features got broken accidentally.

To do so, start by looking at tst/test-compile/ to see how the tests there are set up. Then add more tests, by writing test files which make use of various language features.

To get an idea about what is (not) being tested right now, you can look at the codecov output, i.e. at https://codecov.io/gh/gap-system/gap/src/master/src/compiled.h and https://codecov.io/gh/gap-system/gap/src/master/src/compiler.c
@fingolfin fingolfin added good first issue Issues that can be understood and addressed by newcomers to GAP development topic: tests issues or PRs related to tests labels Mar 7, 2018
@fingolfin
Copy link
Member Author

This is partially addressed by PR #2258

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Mar 21, 2019
@ruthhoffmann ruthhoffmann added the gapdays2020-spring Issues and PRs that arose in relation to https://www.gapdays.de/gapdays2020-spring label Nov 6, 2019
@fingolfin fingolfin removed the gapdays2020-spring Issues and PRs that arose in relation to https://www.gapdays.de/gapdays2020-spring label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fingolfin @ruthhoffmann