Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "strict" mode #1191

Open
fingolfin opened this issue Mar 16, 2017 · 1 comment
Open

Add a "strict" mode #1191

fingolfin opened this issue Mar 16, 2017 · 1 comment
Labels
gapdays2017-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2017-spring good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: kernel

Comments

@fingolfin
Copy link
Member

fingolfin commented Mar 16, 2017

Let's add a strict mode (like e.g. perl has) which warns resp. errors on extra things:

This mode could be enabled or disabled via a command line switch.

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Mar 16, 2017
@olexandr-konovalov olexandr-konovalov added the gapdays2017-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2017-spring label Mar 16, 2017
@fingolfin fingolfin added topic: kernel good first issue Issues that can be understood and addressed by newcomers to GAP development labels Jul 14, 2017
@fingolfin
Copy link
Member Author

fingolfin commented Jul 14, 2017

So to elaborate a bit, here is what I'd do:

  • add a global boolean flag to the kernel, say StrictMode, which defaults to 0 / false.
  • add a command line option --strict which changes the default to 1 / true (can be added in src/system.c next to the other command line options)
  • then look at the code in the two pull requests referenced above; try to adapt their patches so that their warnings are only printed if StrictMode is 1 / true.
  • think about other things it could do, and/or ask about
  • also consider exposing the state of the mode to the GAP language level somehow (say by setting a global variable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2017-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2017-spring good first issue Issues that can be understood and addressed by newcomers to GAP development kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: kernel
Projects
None yet
Development

No branches or pull requests

2 participants