Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP4stones in tst files, unify them? #1021

Closed
hungaborhorvath opened this issue Dec 15, 2016 · 5 comments
Closed

GAP4stones in tst files, unify them? #1021

hungaborhorvath opened this issue Dec 15, 2016 · 5 comments

Comments

@hungaborhorvath
Copy link
Contributor

hungaborhorvath commented Dec 15, 2016

Where can one find the documentation for GAP4stones? I sort of figured (by running make teststandard) that these are supposed to somehow give an indication on how long a test will run.
However, I cannot find anywhere this documented in a proper way. Nor do I see that the numbers in the tst files are anything more than ad-hoc. I certainly have no idea what numbers to put into tst files, I just copied over the number from another file.

Maybe at some point it would be nice to have these numbers align with each other, and also to document the meaning of these numbers.

@olexandr-konovalov olexandr-konovalov changed the title GAPStones in tst files, unify them? GAP4stones in tst files, unify them? Dec 15, 2016
@olexandr-konovalov
Copy link
Member

@hungaborhorvath numbers are periodically renormalised (cf #666), so don't worry too much about placing arbitrary number. I don't mind if GAP4stones will disappear at all, but taking them out is not in my priority list.

@james-d-mitchell
Copy link
Contributor

@hungaborhorvath and @alex-konovalov just to mention that this is related to Issue #446. I too wouldn't mind if GAP4stones disappeared.

@ChrisJefferson
Copy link
Contributor

My personal preference would be to kill GAP4stones.. they don't really mean anything, and they mean even less now we are frequently extending the testsuite (as they are based on how long the tests take to run).

@Stefan-Kohl
Copy link
Member

Stefan-Kohl commented Dec 18, 2016

Yes, probably. -- Of course for compatibility, STOP_TEST should then just ignore the second argument if it is given (and not throw an error).

@olexandr-konovalov
Copy link
Member

GAP4stones were removed in #1072.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants