From fe8ebaeccf5478d3b44c962046fab093f592b6e7 Mon Sep 17 00:00:00 2001 From: Alexander Hulpke Date: Tue, 1 Jan 2019 13:47:16 +0200 Subject: [PATCH] FIX: Only store induced FF setup as own, if it is I.e. do not store an FF setup if the factor has a radical -- code often assume that the given radical factor is indeed fitting free. Subsequent manual changes --- lib/fitfree.gi | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/fitfree.gi b/lib/fitfree.gi index e45b74f4e9..33250698b5 100644 --- a/lib/fitfree.gi +++ b/lib/fitfree.gi @@ -166,15 +166,17 @@ local ffs,hom,U,rest,ker,r,p,l,i,depths; U!.cachedFFS:=[[ffs,r]]; - # FittingFreeLiftSetup for U - r:=rec(inducedfrom:=ffs, - pcgs:=ipcgs, - depths:=depths, - pcisom:=ffs.pcisom, - radical:=ker, - factorhom:=rest - ); - SetFittingFreeLiftSetup(U,r); + # FittingFreeLiftSetup for U, if correct + if Size(RadicalGroup(Image(rest,U)))=1 then + r:=rec(inducedfrom:=ffs, + pcgs:=ipcgs, + depths:=depths, + pcisom:=ffs.pcisom, + radical:=ker, + factorhom:=rest + ); + SetFittingFreeLiftSetup(U,r); + fi; return U;