Skip to content

Commit

Permalink
Add a RedispatchOnCondition to SubdirectProductOp (#3437)
Browse files Browse the repository at this point in the history
Since some aspects of being a group homomorphism are Properties, not
Categories, we need to allow for the chance that some mapping doesn't
know it is a homomorphism, but is. This can't happen in a call from
SubdirectProduct, but could happen if the operations is ever called
from elsewhere.
  • Loading branch information
stevelinton authored Aug 19, 2019
1 parent 28d29fa commit e92eecd
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lib/gprd.gi
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,12 @@ end);
##
#M SubdirectProduct( <G1>, <G2>, <phi1>, <phi2> )
##

RedispatchOnCondition(SubdirectProductOp, "check mappings", true,
[IsGroup, IsGroup, IsGeneralMapping, IsGeneralMapping],
[IsObject, IsObject, IsGroupHomomorphism, IsGroupHomomorphism],
10);

InstallMethod( SubdirectProductOp,"groups", true,
[ IsGroup, IsGroup, IsGroupHomomorphism, IsGroupHomomorphism ], 0,
function( G, H, gh, hh )
Expand Down

0 comments on commit e92eecd

Please sign in to comment.