From d72e6b34abd6f1d062b0c519f14a3e1c198cfaa7 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 30 May 2019 11:39:16 +0200 Subject: [PATCH] BuildPackages.sh: "make clean" before full build This way, if a user re-runs BuildPackages.sh in order to re-build packages, there is a higher chance that this works as expected, instead of mixing old compilation results with new ones. For GAP packages with non-autoconf based build systems, we re-run configure after the `make clean`, as for many of them, the latter removes their generated Makefile (in violation of well-established UNIX conventions). --- bin/BuildPackages.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/BuildPackages.sh b/bin/BuildPackages.sh index 6c60cecee6..d0121c2f66 100755 --- a/bin/BuildPackages.sh +++ b/bin/BuildPackages.sh @@ -168,8 +168,11 @@ run_configure_and_make() { if grep Autoconf ./configure > /dev/null then echo_run ./configure --with-gaproot="$GAPROOT" $CONFIGFLAGS + echo_run "$MAKE" clean else echo_run ./configure "$GAPROOT" + echo_run "$MAKE" clean + echo_run ./configure "$GAPROOT" fi echo_run "$MAKE" else