Skip to content

Commit d51d458

Browse files
committed
ENHANCE: Slight update of heuristic for matgroup niceo
for the unlikely case that a lot of tiny matrix groups are created. This resolves #2133
1 parent fa94fef commit d51d458

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

lib/grpffmat.gi

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,16 +143,21 @@ end );
143143
InstallMethod( NiceMonomorphism, "falling back on GL", true,
144144
[ IsFFEMatrixGroup and IsFinite ], 0,
145145
function( grp )
146+
local tt;
146147
# is it GL?
147148
if (HasIsNaturalGL( grp ) and IsNaturalGL( grp ))
148149
or (HasIsNaturalSL( grp ) and IsNaturalSL( grp )) then
149150
return NicomorphismFFMatGroupOnFullSpace(grp);
150151
fi;
151152

152-
# is the GL domain small enough to simply use it?
153+
# is the GL domain small enough in comparison to the group to simply use it?
154+
tt:=2000;
155+
if HasSize(grp) and Size(grp)<tt then
156+
tt:=Size(grp);
157+
fi;
153158
if IsTrivial(grp)
154-
or Size(FieldOfMatrixGroup(Parent(grp)))^DimensionOfMatrixGroup(grp)
155-
>2000 then
159+
or Size(FieldOfMatrixGroup(Parent(grp)))^DimensionOfMatrixGroup(grp)>tt
160+
then
156161
# if the permutation image would be too large, compute the orbit.
157162
TryNextMethod();
158163
fi;

0 commit comments

Comments
 (0)