From 9ee988f069b8f43646ef968d6ece28daf6ea1a24 Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Wed, 21 Nov 2018 10:16:47 +0100 Subject: [PATCH] semipperm.gi: fix RankOfPartialPermSemigroup for groups Resolves #3037. --- lib/semipperm.gi | 10 +++++----- tst/testinstall/semipperm.tst | 3 +++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/semipperm.gi b/lib/semipperm.gi index 6609bf5897..21e03d8a32 100644 --- a/lib/semipperm.gi +++ b/lib/semipperm.gi @@ -94,17 +94,17 @@ InstallMethod(CodegreeOfPartialPermSemigroup, s-> DegreeOfPartialPermSemigroup(s)); InstallMethod(RankOfPartialPermSemigroup, -"for a partial perm semigroup", +"for a partial perm semigroup with generators of semigroup", [IsPartialPermSemigroup and HasGeneratorsOfSemigroup], S -> RankOfPartialPermCollection(GeneratorsOfSemigroup(S))); InstallMethod(RankOfPartialPermSemigroup, -"for a partial perm semigroup", -[IsPartialPermSemigroup and HasGeneratorsOfGroup], -S -> RankOfPartialPermCollection(GeneratorsOfGroup(S))); +"for a partial perm monoid", +[IsPartialPermMonoid], +S -> RankOfPartialPerm(One(S))); InstallMethod(RankOfPartialPermCollection, -"for a partial perm semigroup", +"for a partial perm semigroup with generators of semigroup", [IsPartialPermSemigroup and HasGeneratorsOfSemigroup], s-> RankOfPartialPermCollection(GeneratorsOfSemigroup(s))); diff --git a/tst/testinstall/semipperm.tst b/tst/testinstall/semipperm.tst index 59f387c516..b160b03660 100644 --- a/tst/testinstall/semipperm.tst +++ b/tst/testinstall/semipperm.tst @@ -87,6 +87,9 @@ gap> RankOfPartialPermSemigroup(S); gap> S := Group(PartialPerm([]));; gap> RankOfPartialPermSemigroup(S); 0 +gap> S := Group([], PartialPerm([1, 2]));; +gap> RankOfPartialPermSemigroup(S); +2 # Test Domain/ImageOfPartialPermCollection/Semigroup gap> S := Semigroup(PartialPerm([1, 2, 3], [4, 5, 11]),