Skip to content

Commit 8a338d7

Browse files
committed
Fix incorrect IsFinitelyGeneratedMonoid method
A finite generating set implies finite generation; but an infinite generating set does not mean that there cannot be a finite one, too.
1 parent 1c4dd9d commit 8a338d7

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/monofree.gi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ InstallGlobalFunction( FreeMonoid, function( arg )
260260
SetIsTrivial( M, false );
261261
SetIsFinite( M, false );
262262
SetIsCommutative(M, false );
263+
SetIsFinitelyGeneratedMonoid(M, false);
263264
fi;
264265

265266
SetIsFreeMonoid( M, true);

lib/monoid.gi

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,10 @@ end);
304304
InstallMethod( IsFinitelyGeneratedMonoid, "for a monoid",
305305
[ IsMonoid and HasGeneratorsOfMonoid ],
306306
function(M)
307-
return IsFinite(GeneratorsOfMonoid(M));
307+
if IsFinite(GeneratorsOfMonoid(M)) then
308+
return true;
309+
fi;
310+
TryNextMethod();
308311
end);
309312

310313

0 commit comments

Comments
 (0)