Apply suggestions from code review

Co-Authored-By: Max Horn <max@quendi.de>
gap-system · Apr 15, 2020 · 6c5fa79 · 6c5fa79
1 parent a6fb085
commit 6c5fa79
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/sysfiles.c b/src/sysfiles.c
@@ -680,11 +680,11 @@ Int SyFopen (
 #endif
 
     /* try to open the file                                                */
-    if(endsgz && (syBuf[fid].gzfp = gzopen(name, mode))) {
+    if (endsgz && (syBuf[fid].gzfp = gzopen(name, mode))) {
         syBuf[fid].type = gzip_socket;
         syBuf[fid].fp = -1;
         syBuf[fid].bufno = -1;
-    } else if ( 0 <= ( syBuf[fid].fp = open(name,flags, 0644))) {
+    } else if (0 <= (syBuf[fid].fp = open(name, flags, 0644))) {
         syBuf[fid].type = raw_socket;
         syBuf[fid].echo = syBuf[fid].fp;
         syBuf[fid].bufno = -1;

diff --git a/tst/testinstall/compressed.tst b/tst/testinstall/compressed.tst
@@ -14,22 +14,22 @@ gap> isGzippedFile := function(dir, name)
 gap> str := "hello\ngoodbye\n";;
 
 # Write a compressed file
-gap> FileString( Filename(dir, "test.g.gz"), str ) = Length(str);
+gap> FileString( fname, str ) = Length(str);
 true
 
 # Check file really is compressed
 gap> isGzippedFile(dir, "test.g.gz");
 true
 
 # Check reading compressed file
-gap> StringFile( Filename(dir, "test.g.gz") ) = str;
+gap> StringFile( fname ) = str;
 true
 
 # Check gz is added transparently
 gap> StringFile( Filename(dir, "test.g") ) = str;
 true
 
-# Test reading/seeking
+# Test reading/seeking in a gzip compressed file
 gap> stream := InputTextFile(fname);;
 gap> ReadLine(stream);
 "hello\n"