Skip to content

Commit

Permalink
Revert "semipperm.gi: fix RankOfPartialPermSemigroup for groups"
Browse files Browse the repository at this point in the history
This reverts commit 16ec90c. The
changed made there makes testinstall and teststandard fail when
all packages are loaded, because it requires the new version of
the Semigroups package.
  • Loading branch information
Alexander Konovalov committed Nov 30, 2018
1 parent 07b934f commit 465d77e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
10 changes: 5 additions & 5 deletions lib/semipperm.gi
Original file line number Diff line number Diff line change
Expand Up @@ -94,17 +94,17 @@ InstallMethod(CodegreeOfPartialPermSemigroup,
s-> DegreeOfPartialPermSemigroup(s));

InstallMethod(RankOfPartialPermSemigroup,
"for a partial perm semigroup with generators of semigroup",
"for a partial perm semigroup",
[IsPartialPermSemigroup and HasGeneratorsOfSemigroup],
S -> RankOfPartialPermCollection(GeneratorsOfSemigroup(S)));

InstallMethod(RankOfPartialPermSemigroup,
"for a partial perm monoid",
[IsPartialPermMonoid],
S -> RankOfPartialPerm(One(S)));
"for a partial perm semigroup",
[IsPartialPermSemigroup and HasGeneratorsOfGroup],
S -> RankOfPartialPermCollection(GeneratorsOfGroup(S)));

InstallMethod(RankOfPartialPermCollection,
"for a partial perm semigroup with generators of semigroup",
"for a partial perm semigroup",
[IsPartialPermSemigroup and HasGeneratorsOfSemigroup],
s-> RankOfPartialPermCollection(GeneratorsOfSemigroup(s)));

Expand Down
3 changes: 0 additions & 3 deletions tst/testinstall/semipperm.tst
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ gap> RankOfPartialPermSemigroup(S);
gap> S := Group(PartialPerm([]));;
gap> RankOfPartialPermSemigroup(S);
0
gap> S := Group([], PartialPerm([1, 2]));;
gap> RankOfPartialPermSemigroup(S);
2

# Test Domain/ImageOfPartialPermCollection/Semigroup
gap> S := Semigroup(PartialPerm([1, 2, 3], [4, 5, 11]),
Expand Down

0 comments on commit 465d77e

Please sign in to comment.