-
Notifications
You must be signed in to change notification settings - Fork 2
CI: Build semigroups (and cascade of dependencies) #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
james-d-mitchell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, let’s see if the CI passes
|
Build manuals fails because there's no manual. It'd probably make sense to remove that ci job |
limakzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no documentation, as @james-d-mitchell mentioned, please remove build-docs step.
limakzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion.
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
|
Since the documentation step was moved to a separate file in c931949, I think it should be fine to merge this PR as is; a removal of `docs.yml' file can be done in a separate PR. (I think there's something to be said for just leaving the failing Docs job in place, as a reminder that documentation is missing, but I leave the decision on that to others :) ) |
Closes #10.