Skip to content

Conversation

@stertooy
Copy link

Closes #10.

Copy link

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, let’s see if the CI passes

@james-d-mitchell
Copy link

Build manuals fails because there's no manual. It'd probably make sense to remove that ci job

Copy link

@limakzi limakzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no documentation, as @james-d-mitchell mentioned, please remove build-docs step.

Copy link

@limakzi limakzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion.

james-d-mitchell and others added 2 commits October 21, 2025 18:26
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
@stertooy
Copy link
Author

Since the documentation step was moved to a separate file in c931949, I think it should be fine to merge this PR as is; a removal of `docs.yml' file can be done in a separate PR.

(I think there's something to be said for just leaving the failing Docs job in place, as a reminder that documentation is missing, but I leave the decision on that to others :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: tests don't run because semigroups is not being built

3 participants