Accommodate future changed ViewStrings in GAP #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 84.85% 84.13% -0.72%
==========================================
Files 13 13
Lines 3354 3234 -120
==========================================
- Hits 2846 2721 -125
- Misses 508 513 +5
|
olexandr-konovalov
approved these changes
May 14, 2020
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to gap-system/gap#3992, phrases like "1 generators" in ViewStrings of GAP objects will soon instead be correctly pluralised as "1 generator". I think this PR changes the only test that would be affected by this change. As far as I can tell, manual examples are not affected.