Mark nice monomorphisms explicitly as injective #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids potential bugs when code tries to compute kernels of nice monos
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 76.15% 76.16%
=======================================
Files 16 16
Lines 7818 7820 +2
=======================================
+ Hits 5954 5956 +2
Misses 1864 1864
|
|
Looks OK. |
|
The corresponding XMod failures are (hopefully) all due to calling these groupoid methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids potential bugs when code tries to compute kernels of nice monos
For some background:
IsInjectiveset (otherwise an infinite recursion can happen) gap-system/gap#5029