Skip to content

Commit 47fa502

Browse files
committed
[Task] code standards improvements on logger template
1 parent f1505bf commit 47fa502

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

templates/logger/Logger/${LoggerName}.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,12 @@ class ${LoggerName} extends Logger
2525
/**
2626
* {@inheritdoc}
2727
*/
28-
public function __construct(HandlerFactory $handlerFactory, $name = '${loggerName}', array $handlers = [], array $processors = [])
29-
{
28+
public function __construct(
29+
HandlerFactory $handlerFactory,
30+
$name = '${loggerName}',
31+
array $handlers = [],
32+
array $processors = []
33+
) {
3034
foreach ($this->defaultHandlerTypes as $handlerType) {
3135
if (!array_key_exists($handlerType, $handlers)) {
3236
$handlers[$handlerType] = $handlerFactory->create($handlerType);

templates/logger/Logger/Handler/HandlerFactory.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ class HandlerFactory
2727
* @var string
2828
*/
2929
protected $instanceTypeNames = [
30-
'error' => '\\${Vendorname}\\${Modulename}\\Logger\\Handler\\Error',
31-
'info' => '\\${Vendorname}\\${Modulename}\\Logger\\Handler\\Info',
32-
'debug' => '\\${Vendorname}\\${Modulename}\\Logger\\Handler\\Debug',
30+
'error' => \${Vendorname}\${Modulename}\Logger\Handler\Error::class,
31+
'info' => \${Vendorname}\${Modulename}\Logger\Handler\Info::class,
32+
'debug' => \${Vendorname}\${Modulename}\Logger\Handler\Debug::class,
3333
];
3434

3535
/**
@@ -49,15 +49,16 @@ public function __construct(ObjectManagerInterface $objectManager)
4949
* @param array $data
5050
* @return ObjectType
5151
*/
52-
public function create($type, array $data = array())
52+
public function create($type, array $data = [])
5353
{
5454
if (empty($this->instanceTypeNames[$type])) {
5555
throw new InvalidArgumentException('"' . $type . ': isn\'t allowed');
5656
}
5757

5858
$resultInstance = $this->objectManager->create($this->instanceTypeNames[$type], $data);
5959
if (!$resultInstance instanceof ObjectType) {
60-
throw new InvalidArgumentException(get_class($resultInstance) . ' isn\'t instance of \${Vendorname}\${Modulename}\Logger\Handler\HandlerAbstract');
60+
throw new InvalidArgumentException(get_class($resultInstance) .
61+
' isn\'t instance of \${Vendorname}\${Modulename}\Logger\Handler\HandlerAbstract');
6162
}
6263

6364
return $resultInstance;

0 commit comments

Comments
 (0)