Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a little problem with columnWrapperStyle #15

Closed
treemore opened this issue Jul 12, 2017 · 6 comments
Closed

a little problem with columnWrapperStyle #15

treemore opened this issue Jul 12, 2017 · 6 comments

Comments

@treemore
Copy link

https://github.com/gameboyVito/react-native-ultimate-listview/blob/master/src/ultimateListView.js#L473

maybe there must be this.props.columnWrapperStyle.

your lib help me mush. thank you

@gameboyVito
Copy link
Owner

Thanks for pointing out, already fixed @3.1.5.

@treemore
Copy link
Author

i think the flatlist component is not good for a production . it is more quick than ListView ,but it will more cpu,always let my app can not response touch event .
so legacyImplementation={true} is very important

@gameboyVito
Copy link
Owner

You can use the stable version @3.0.2. Thx~

@treemore
Copy link
Author

<UltimateListView
legacyImplementation={true}
onFetch={this.onFetch}
refreshableMode="advanced"
item={this.renderItem}
keyExtractor={(item) => ('hot-' + item._id + keySeed++)}
numColumn={1}

            />

"react": "16.0.0-alpha.12",
"react-native": "0.46.1", // "react-native": "0.46.2", is not working too.
"react-native-ultimate-listview": "3.0.2",

the onFetch method i had checked ,no error . the backend return the right data.

but the UltimateListView just show loading... forever .

when i set legacyImplementation={false} ,the same.
when i set refreshableMode="basic" , the same .

@treemore
Copy link
Author

most time . react-native-ultimate-listview@3.1.5 is working perfect with legacyImplementation={true}.
except
https://github.com/gameboyVito/react-native-ultimate-listview/blob/master/src/ultimateListView.js#L237
i get a warning . Cannot read property 'endRefresh' of undefined. maybe is need a check for legacyImplementation. Although it does not seem to affect

@treemore
Copy link
Author

facebook/react-native#12884
Touch event in the FlatList is delay . let the touch event too slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants