Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make at least two colors of smart cable be part of the ae2 device #465

Closed
Discord-Github-Bridge opened this issue Jan 3, 2024 · 25 comments

Comments

@Discord-Github-Bridge
Copy link
Collaborator

this is both nice for backwards compat with the light blue cables, and allows for some decoration and cable shenanigans that wouldn't otherwise be available.

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

Agreed. Since you are not the one crafting them we can assume they are smart enough to change colors and let you change all of them

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

wait I should ping pending code contributors maybe...

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

i don't seem to have permission for that but it might just be mobiles bad ui

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

Everyone has permission for pings here i think

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

<@&1181024760730226708> if anyone wants to add the colored versions of me cables to the network devices that could be a nice first contribution

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

the file is kubejs/server_scripts/base/featrues/devices.js

@TheFarawayDev
Copy link

I might if I have time after school...

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

should they all be accessible?

@TheFarawayDev
Copy link

Yes

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

i think there's an argument to be made to keep the color pool low so there's a consistent asthetic

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

a facade could also be nice, like one for a specific block

@TheFarawayDev
Copy link

So fake blocks for the cables?

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

im pretty sure you can't get the blocks back out of a facade in any way so it should be safe to make it part of the device

@TheFarawayDev
Copy link

NOTES:

  • Wants Facade
  • New Color Cables

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

hm.. maybe. but it will feel wierd to have some colores a device and some manual. I think we should either have them all or have the others removed

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

i don't think all colors are really necessary

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

do you think it'd be reasonable to have the color applicator

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

it doesn't let you dye very many blocks, notably for us it doesn't let you dye concrete powder

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

it's an energy gadget which feels like it's antithetical

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

also we could do something like let the dense cables and/or the non-covered cables be all 16 colors

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

and have those be their own device tier

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

sharing space with the controller

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

i think that makes sense given the controllers propensity towards being pretty colorful

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

for now i made all 16 colors be able to convert to none colored

@EngineerSmith
Copy link
Collaborator

I don't believe this issue is needed anymore as we're moving to uncoloured with devices. Even the wreck ship will use uncoloured smart cables by #554

So reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants