Add a fence to the spaceship somewhere

[TulkinRB]

So people can tie Betsy's lead somewhere early game

[Yarden-zamir]

Are there none wood fences?

[TulkinRB]

Unfortunately not :(

There are stone walls, but I think you can't tie leads to them. As for metal there are none.

I thought about making create's girder stuff work with leads but for now we can add a fence

[Yarden-zamir]

I don't like the idea of adding a wooden fence, feels weird. Lets add a fence to gray plate

[TulkinRB]

I'm all for it but we need to figure out how to make leads actually tie to it

[Yarden-zamir]

I think if it's a fence type it should be automatic, look at how to make a fence in kjs and I expect it will work out of the box

found this on the discord https://discord.com/channels/303440391124942858/890391356650958918/890426708589678642

[Yarden-zamir]

Now that we have a fence, this should be a thing

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

I'll do it when I update the ship with the new crates

[Discord-Github-Bridge]

yarden.zamir on Discord says

awesome

[Discord-Github-Bridge]

yarden.zamir on Discord says

engineersmith_4628 what's the status on editing the ship?

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

Was waiting for my PR to be accepted - that was all. I can go ahead wit hit now

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

I'm not sure the modpack itself has the new mod version tho looking at the main repos PRs

[Discord-Github-Bridge]

yarden.zamir on Discord says

Oh, I don't see an open pr to update though

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

They were all closed by Kiki

[Discord-Github-Bridge]

yarden.zamir on Discord says

kikis2111 is the latest version broken or something?

[Discord-Github-Bridge]

yarden.zamir on Discord says

In general the auto pr is built on the assumption that main always runs so if you have something incomplete a branch is a better place for it

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

I think there's an issue with version names updating on push in branches. Since each time I did a push it would increment the version

[Discord-Github-Bridge]

yarden.zamir on Discord says

Ah, maybe the ci runs on all branches partially? I'll take a look, thought I filtered for main

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

I may of forgot to make my own branches, so I meant fork more so. I pushed to main on my fork which updated the version. That probably broke things

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

https://github.com/EngineerSmith/ptdye-plus/commits/main/
Like half of these were merge fixes lmao and then as I didn't pull. It wanted more merges

[Discord-Github-Bridge]

yarden.zamir on Discord says

o

[Discord-Github-Bridge]

yarden.zamir on Discord says

i thought forks dont have the original ci

[Discord-Github-Bridge]

kikis2111 on Discord says

yeah there is something going wrong with the ci task, fixing it now then will make sure engineers code is included in the latest pr

[Discord-Github-Bridge]

kikis2111 on Discord says

dont approve any version update pr's for now yarden

[Discord-Github-Bridge]

yarden.zamir on Discord says

alright, keep me posted

[Discord-Github-Bridge]

kikis2111 on Discord says

engineersmith_4628 can you disable the workflow on your fork

[Discord-Github-Bridge]

kikis2111 on Discord says

it should be disabled by default

[Discord-Github-Bridge]

kikis2111 on Discord says

testing your code now engin

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

Disabled 👍

[Discord-Github-Bridge]

kikis2111 on Discord says

cool

[Discord-Github-Bridge]

kikis2111 on Discord says

yarden.zamir seems to be a problem with curseforge approving the files for release

[Discord-Github-Bridge]

kikis2111 on Discord says

so the when the pr task runs it runs packwiz update curseforge but the latest release hasnt been approved

[Discord-Github-Bridge]

yarden.zamir on Discord says

oh lol, that makes sense

[Discord-Github-Bridge]

kikis2111 on Discord says

so having to manually update the curseforge files

[Discord-Github-Bridge]

kikis2111 on Discord says

each time

[Discord-Github-Bridge]

yarden.zamir on Discord says

hm

[Discord-Github-Bridge]

kikis2111 on Discord says

need a timer

[Discord-Github-Bridge]

kikis2111 on Discord says

like wait 30mins then run packwiz update

[Discord-Github-Bridge]

yarden.zamir on Discord says

sure, add a few minutes sleep to the cf one

[Discord-Github-Bridge]

yarden.zamir on Discord says

but add a cuncurency group cancel, so if more jobs come the old ones get canceled

[Discord-Github-Bridge]

yarden.zamir on Discord says

dont remember the exact terminology

[Discord-Github-Bridge]

kikis2111 on Discord says

hm ok

[Discord-Github-Bridge]

kikis2111 on Discord says

latest pr is ready to go yarden

[Discord-Github-Bridge]

kikis2111 on Discord says

i think each job has to finish, otherwise there will be version mismatches between github and curseforge/modrinth

[Discord-Github-Bridge]

kikis2111 on Discord says

if a job is cancelled somewhere in the middle

[Discord-Github-Bridge]

engineersmith_4628 on Discord says

I heard someone asked for a fence