use same instead of foo

Author: aoloe

qt-5-pyqt5/README.md

@@ -1,9 +1,4 @@
-# qt application calling a python script accessing the c++ API of the application
-
-- Create a `.so` module.
-- Call the Python script from the c++ code and pass a variable per reference.
-- The Python script loads the module and modify the variable.
-- The c++ code checks that the values has been modified
+# Encapsulate the scripter in a class
 
 ~~~.sh
 $ mkdir build
@@ -14,6 +9,5 @@ $ ./sample
 
 ## Notes
 
-- On a mac with Qt from homebrew you need:  
-  `cmake .. -GXcode -DQt5Widgets_DIR=/usr/local/Cellar/qt/5.9.1/lib/cmake/Qt5Widgets`
+- running twice `run()`, produces a crash.
 - If you prefer you can symlink pybind11 directory and replace the `find_package` with `add_subdirectory` in `CMakeLists.txt`

qt-5-pyqt5/python/set-bar.py

@@ -1,7 +1,5 @@
 import sampleapi
 
-print(foo_copy.bar)
-foo_copy.bar = 5
-print(foo_copy.bar)
-foo_ref.bar = 5
+print(Sample.bar)
+Sample.bar = 5
 

qt-5-pyqt5/src/mainwindow.cpp

@@ -29,7 +29,7 @@ void MainWindow::scriptRun()
 {
 	QString fileName = QFileDialog::getOpenFileName(this,
 		// tr("Open Image"), QStandardPaths::standardLocations(QStandardPaths::HomeLocation).last(), tr("Image Files (*.py *.png *.jpg *.bmp)"));
-		tr("Open Image"), SCRIPTS_DIRECTORY, tr("Image Files (*.py *.png *.jpg *.bmp)"));
+		tr("Open Script"), SCRIPTS_DIRECTORY, tr("Python Files (*.py)"));
     qDebug() << "fileName" << fileName;
     std::cout << "filename: " << fileName.toStdString() << std::endl;
 

qt-5-pyqt5/src/scripter.cpp

@@ -5,14 +5,13 @@ using namespace pybind11::literals; // for the ""_a
 
 void Scripter::runFile(std::string fileName)
 {
-	ScripterAPI foo1, foo2;
+	ScripterAPI api;
 
 	auto module = py::module::import("sampleapi");
 
-	auto locals = py::dict("foo_copy"_a=foo1, "foo_ref"_a=py::cast(foo2, py::return_value_policy::reference)); // foo1 by value, foo2 by reference
+	auto locals = py::dict("Sample"_a=py::cast(api, py::return_value_policy::reference));
 
     py::eval_file(fileName, py::globals(), locals);
 
-	assert(foo1.bar == 1);
-	assert(foo2.bar == 5);
+	assert(api.bar == 5);
 }

qt-5-pyqt5/src/scripterAPI.h

@@ -1,7 +1,8 @@
 #ifndef SCRIPTERAPI_H
 #define SCRIPTERAPI_H
-struct ScripterAPI
+class ScripterAPI
 {
-    int bar = 1;
+    public:
+        int bar = 1;
 };
 #endif