Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show welcome after OIDC login #8099

Open
Tracked by #5817
hexylena opened this issue Jun 5, 2019 · 3 comments
Open
Tracked by #5817

Show welcome after OIDC login #8099

hexylena opened this issue Jun 5, 2019 · 3 comments
Labels
area/auth Authentication and authorization area/UI-UX kind/bug

Comments

@hexylena
Copy link
Member

hexylena commented Jun 5, 2019

I'm testing release_19.05 currently, and noticed that after logging in with OIDC, we get a blank main panel (normally would be white, I have browser css to make it black.) It would be helpful if this showed the normal welcome.html instead

image

@hexylena hexylena added area/UI-UX area/auth Authentication and authorization labels Jun 5, 2019
@hexylena
Copy link
Member Author

hexylena commented Jun 6, 2019

@VJalili would you be able to take a look at this? We're getting ready to deploy elixir OIDC with 19.05 and I worry about the user experience here.

@hexylena
Copy link
Member Author

hexylena commented Jun 6, 2019

Another note, I accidentally hit refresh today after doing a test, the URL was still set to the elixir callback and it attempted to resubmit that generating an error. If we can redirect to / after the callback this would be optimal I think

@martenson martenson added kind/bug area/auth Authentication and authorization and removed area/auth Authentication and authorization labels Jun 6, 2019
@VJalili
Copy link
Member

VJalili commented Jun 6, 2019

noticed that after logging in with OIDC, we get a blank main panel ... It would be helpful if this showed the normal welcome.html instead

@dannon any thoughts?

# TODO: this doesn't properly redirect when login is done
# (see webapp __ensure_logged_in_user for the initial redirect - not sure why it doesn't redirect to login?)
login_url = web.url_for(controller="root", action="login")

Another note, I accidentally hit refresh today after doing a test, the URL was still set to the elixir callback and it attempted to resubmit that generating an error.

I wonder if this is related to the previous issue, because after callback is handled that URL should not be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Authentication and authorization area/UI-UX kind/bug
Projects
None yet
Development

No branches or pull requests

3 participants