Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join two Datasets (Galaxy Version 2.1.1) -- incorrectly inherits 1st input's datatype #6107

Closed
jennaj opened this issue May 9, 2018 · 2 comments

Comments

@jennaj
Copy link
Member

jennaj commented May 9, 2018

Problem: This tool used to always produce tabular/interval output (depending on the inputs) in some earlier version no longer available on the usegalaxy.org server.

Version 2.1.0 was incorrectly assigning the datatype data to outputs and that was addressed to produce version 2.1.1.

As of version 2.1.1, the tool inherits the datatype of the first input. If that datatype is not tabular or interval, an incorrect datatype assignment can be made. This causes downstream tools errors and breaks the 101 Tutorial.

First reported as part of this ticket: galaxyproject/usegalaxy-playbook#46

Test history: https://usegalaxy.org/u/jen/h/copy-of-courseegexons-and-repeats

Tests from 18.01:

Input dataset 1 bed first + 4 tabular second (following the 101 protocol). Result dataset 9 from tool version 2.1.1 is assigned bed but is really in interval (or tabular). Out of spec for bed.

Dataset 8 uses same inputs, but tool version 2.1.0, and is an example of the prior incorrect assignment of data for the datatype.

Rerun using 18.05: Shows that the datatype is coming from the 1st input.

  • dataset 19, same result, bed (out of spec)

  • flip the inputs, dataset 26 tabular now (ok, but interval would be better)

@jennaj
Copy link
Member Author

jennaj commented Oct 26, 2018

Still a bug at ORG under pre-release 18.09 -- tool creates an out-of-spec bed result (inherits 1st input's datatype). Same test history was used.

@jennaj
Copy link
Member Author

jennaj commented Dec 3, 2018

Works under dev repos in a local. Can track update to Main 19.01 in the playbook ticket and test once pre-release is installed: galaxyproject/usegalaxy-playbook#46

@jennaj jennaj closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants