HDCA Deletion Broken in 18.01.

[jmchilton]

From @mvdbeek:

I think previously permanently deleting a HDCA resulted in the datasets being deleted as well
Now deleting an HDCA doesn't do anything, I think
except for deleting the HDCA in the history

General issues maybe can be tracked here (#5402) but I want to make sure the regressions are fixed for 18.01 so I'm creating this issue.

[jmchilton]

@mvdbeek In working on #5442 I saw no code that would lead me to believe that at any point "permanently deleting a HDCA" would delete the datasets as well. There is no link anywhere for permanently deleting an HDCA except for in multi-action menu and it looks like that would be broken - #5117 seems like what I would expect to happen based on the code.

Can I close this out when #5442 or some variant of that is merged?

[mvdbeek]

Absolutely, with these PRs I have nothing to complain about anymore :).