Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Pagination is broken if there are archived histories #16397

Closed
ahmedhamidawan opened this issue Jul 13, 2023 · 3 comments
Closed

History Pagination is broken if there are archived histories #16397

ahmedhamidawan opened this issue Jul 13, 2023 · 3 comments

Comments

@ahmedhamidawan
Copy link
Member

Describe the bug
api/histories/count returns len(current_user.active_histories), which currently includes active+archived histories. We need to change that so that if returns only active, not archived, not deleted histories.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 23.1

To Reproduce
Steps to reproduce the behavior:

  1. Given no histories have been archived, archive one history
  2. Go to the switch to history modal
  3. Scroll down to the end, it'll keep expecting 1 more history, as the total count of histories hasn't changed after the archival
@davelopez
Copy link
Contributor

Good catch, that is actually a backend issue 👍

@davelopez
Copy link
Contributor

Should be fixed by #16400, thanks for discovering it!

@mvdbeek
Copy link
Member

mvdbeek commented Jul 24, 2023

Fixed in #16400

@mvdbeek mvdbeek closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants