Skip to content

Commit 82e5dc0

Browse files
committed
Fix gcloud metadata passing by using separate --metadata flags
Use individual --metadata flags for each key-value pair instead of building one comma-separated string. This avoids parsing issues when values contain special characters like semicolons or slashes.
1 parent a86482e commit 82e5dc0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

bin/launch_vm.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -228,15 +228,15 @@ GCLOUD_CMD=(
228228
--metadata-from-file=user-data=bin/user_data.sh
229229
)
230230

231-
# Build metadata string
232-
METADATA="ssh-keys=ubuntu:$SSH_KEY,galaxy-chart-version=${GALAXY_CHART_VERSION},galaxy-deps-version=${GALAXY_DEPS_VERSION},galaxy-values-files=${GALAXY_VALUES_FILES_LIST}"
231+
# Add metadata using separate flags to avoid parsing issues with special characters
232+
GCLOUD_CMD+=(--metadata ssh-keys="ubuntu:$SSH_KEY")
233+
GCLOUD_CMD+=(--metadata galaxy-chart-version="${GALAXY_CHART_VERSION}")
234+
GCLOUD_CMD+=(--metadata galaxy-deps-version="${GALAXY_DEPS_VERSION}")
235+
GCLOUD_CMD+=(--metadata galaxy-values-files="${GALAXY_VALUES_FILES_LIST}")
233236
if [ "$EPHEMERAL_ONLY" = false ]; then
234-
METADATA="${METADATA},persistent-volume-size=${PV_SIZE}Gi"
237+
GCLOUD_CMD+=(--metadata persistent-volume-size="${PV_SIZE}Gi")
235238
fi
236239

237-
# Add combined metadata
238-
GCLOUD_CMD+=(--metadata="$METADATA")
239-
240240
# Add disk flag if not ephemeral only
241241
if [ "$EPHEMERAL_ONLY" = false ]; then
242242
GCLOUD_CMD+=($DISK_FLAG)

0 commit comments

Comments
 (0)