Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pusher: No error shown on size limit #84

Open
tjwelde opened this issue Mar 13, 2017 · 2 comments
Open

Pusher: No error shown on size limit #84

tjwelde opened this issue Mar 13, 2017 · 2 comments

Comments

@tjwelde
Copy link
Contributor

tjwelde commented Mar 13, 2017

Taken from: BurdaMagazinOrg/thunder-distribution#261 (review)
When I make big post (>10kb), limit for Pusher is 10kb, error occurs in log, that it can't be pushed.
But in live blog form I get success message: "Liveblog post was successfully created."
In log: "Failed to send a message to Pusher. See the request log..."
And also, since it's not pushed to pusher, user does not see post until page is reloaded.
-> maybe it should be considered to notify editor about error occurred. Best would be to not create post in Drupal, if it's not pushed to pusher. In general this should be atomic action, so post is successfully created only if it's created properly in both places -> Pusher + Drupal.

@mbm80
Copy link
Collaborator

mbm80 commented Mar 13, 2017

We had a discussion about the size limit. One solution would be to zip the data (saving about 2/3 of the payload), but ideally you would split the data into packages and put them together in the front end.
Otherwise, yes, there needs to be a message that the data was not transferred as expected.

@tjwelde
Copy link
Contributor Author

tjwelde commented Mar 13, 2017

Thanks for your input.

You can apparently expand the limit by using a dedicated cluster: https://support.pusher.com/hc/en-us/articles/202046553-What-is-the-message-size-limit-when-publishing-a-message-

So the steps to take are:

  • Don't save on error and notify the editor
  • Compress the data
  • (maybe) strip out null values
  • (maybe) strip body_value
  • Document the size limit and inform about option to make a dedicated cluster
  • (future) think about splitting packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants