Skip to content

chore(deps): drop deprecated boolean module #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thisislawatts
Copy link

@thisislawatts thisislawatts commented Jan 16, 2025

Inlines the boolean module to address #70. Code repository is no longer available, code sourced via npm registry.

@thisislawatts thisislawatts marked this pull request as ready for review January 16, 2025 16:39
@thisislawatts
Copy link
Author

Checking in on this, @gajus is this something you would be open to reviewing?

@ghost
Copy link

ghost commented Feb 17, 2025

Came here to see if this is being addressed. 👍 for the PR.

However, it should be noted that this function only parses for truthy and truthy-like values; which means it is not a parse boolean function since anything not truthy/truthy-like is just false. (may be rename to parseTruthy later and update references in codebase)

  • Is the code and intent only to parse the possible truthy/truthy-like values?
  • Did the original boolean package do the same?

I tried testing it for weird values like { valueOf: () => 1 } and new Number(1) and new Number(0) It seems to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant