Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructuring improvements/fixes #540

Open
3 tasks
brettz9 opened this issue May 14, 2020 · 0 comments
Open
3 tasks

Destructuring improvements/fixes #540

brettz9 opened this issue May 14, 2020 · 0 comments

Comments

@brettz9
Copy link
Collaborator

brettz9 commented May 14, 2020

A couple issues on the new destructuring support:

  • Where a root and grandchildren are present but not children, the fixing order is off.
  • As per checkDestructured property to disable destructured checks #532 (review) , we'd like to have clearer messages for reporting destructuring issues. To do this, we need to have a proper function for stringifying a destructured parameter object.
  • Report the proper line numbers

I put the issues together since for implementation, I think it will be easiest to refactor getFunctionParameterNames to handle both cases (perhaps avoiding flattening--need to investigate).


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant