From c7f4a4f9a7a8f16b7728df1155015d323c8b06da Mon Sep 17 00:00:00 2001
From: Bhavani Shankar <ebhavanishankar@gmail.com>
Date: Thu, 1 Feb 2018 15:32:41 +0530
Subject: [PATCH] test: improve error message output

PR-URL: https://github.com/nodejs/node/pull/18498
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
---
 test/addons-napi/test_general/test.js | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/test/addons-napi/test_general/test.js b/test/addons-napi/test_general/test.js
index 15461cef2f6a36..d43a1c69ba0c43 100644
--- a/test/addons-napi/test_general/test.js
+++ b/test/addons-napi/test_general/test.js
@@ -63,22 +63,25 @@ let w = {};
 test_general.wrap(w);
 w = null;
 global.gc();
-assert.strictEqual(test_general.derefItemWasCalled(), true,
+const derefItemWasCalled = test_general.derefItemWasCalled();
+assert.strictEqual(derefItemWasCalled, true,
                    'deref_item() was called upon garbage collecting a ' +
-                   'wrapped object');
+                   'wrapped object. test_general.derefItemWasCalled() ' +
+                   `returned ${derefItemWasCalled}`);
+
 
 // Assert that wrapping twice fails.
 const x = {};
 test_general.wrap(x);
-assert.throws(() => test_general.wrap(x), Error);
+common.expectsError(() => test_general.wrap(x),
+                    { type: Error, message: 'Invalid argument' });
 
 // Ensure that wrapping, removing the wrap, and then wrapping again works.
 const y = {};
 test_general.wrap(y);
 test_general.removeWrap(y);
-assert.doesNotThrow(() => test_general.wrap(y), Error,
-                    'Wrapping twice succeeds if a remove_wrap()' +
-                    ' separates the instances');
+// Wrapping twice succeeds if a remove_wrap() separates the instances
+assert.doesNotThrow(() => test_general.wrap(y));
 
 // Ensure that removing a wrap and garbage collecting does not fire the
 // finalize callback.
@@ -87,8 +90,11 @@ test_general.testFinalizeWrap(z);
 test_general.removeWrap(z);
 z = null;
 global.gc();
-assert.strictEqual(test_general.finalizeWasCalled(), false,
-                   'finalize callback was not called upon garbage collection');
+const finalizeWasCalled = test_general.finalizeWasCalled();
+assert.strictEqual(finalizeWasCalled, false,
+                   'finalize callback was not called upon garbage collection.' +
+                   ' test_general.finalizeWasCalled() ' +
+                   `returned ${finalizeWasCalled}`);
 
 // test napi_adjust_external_memory
 const adjustedValue = test_general.testAdjustExternalMemory();