Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gabrielfeo/develocity-api-kotlin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2024.2.0-alpha01
Choose a base ref
...
head repository: gabrielfeo/develocity-api-kotlin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2024.2.0-alpha02
Choose a head ref
  • 11 commits
  • 28 files changed
  • 4 contributors

Commits on Sep 4, 2024

  1. Bump library version in examples to 2024.2.0-alpha01 (#280)

    Examples tested with a [`check`
    build](https://scans.gradle.com/s/rcpstwc3qo3e2).
    
    ---------
    
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Gabriel Feo <gabriel@gabrielfeo.com>
    3 people authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1d7a97f View commit details
    Browse the repository at this point in the history
  2. Fix version replacement workflow for pre-release (#285)

    ### Issue
    
    When the new version has a qualifier, the current version replacement
    breaks badge URLs. In badges, '-' characters must be "escaped" as '--'.
    
    Replace of '2024.1.1' for '2024.2.0-alpha01' (#280):
    
    - Expected:
    https://img.shields.io/badge/Maven%20Central-2024.2.0--alpha01-blue
    - Actual:
    https://img.shields.io/badge/Maven%20Central-2024.2.0-alpha01-blue
    
    Caused `main` check to fail:
    
    ```
    ERROR: 2 dead links found!
    [✖] https://img.shields.io/badge/Maven%20Central-2024.2.0-alpha01-blue → Status: 404
    [✖] https://img.shields.io/badge/Javadoc-2024.2.0-alpha01-orange → Status: 404
    ```
    
    
    https://github.com/gabrielfeo/develocity-api-kotlin/actions/runs/10705233856/job/29680113989
    
    ### Fix
    
    Add more test scenarios. Fix replacement of versions inside badge URLs,
    according to tests.
    gabrielfeo authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7015fc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix Config.logLevel precedence and javadoc (#286)

    Fix precedence of `Config.logLevel` sources so that environment variable
    is always preferred. Also fix #284.
    gabrielfeo authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    87207b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1c5cb9 View commit details
    Browse the repository at this point in the history
  3. Fix GradleConfigurationCacheResult.Outcome enum naming (#288)

    Fix #282 with generated API post-processing.
    
    >Enum members name casing goes against the Kotlin style guide and will
    pollute client code. Class is only present after library
    v2024.2.0-alpha01.
    >
    >```kotlin
    >    /**
    > * The outcome of the configuration cache operation: * `HIT` - There
    was a configuration cache hit. * `MISS` - There was a configuration
    cache miss. * `FAILED` - There was a configuration cache related
    failure.
    >     *
    >     * Values: hIT,mISS,fAILED
    >     */
    >    @JsonClass(generateAdapter = false)
    >    enum class Outcome(val value: kotlin.String) {
    >        @JSON(name = "HIT") hIT("HIT"),
    >        @JSON(name = "MISS") mISS("MISS"),
    >        @JSON(name = "FAILED") fAILED("FAILED");
    >    }
    >```
    >
    >Occurs when the API spec's `enum` items are upper-case and the Kotlin
    generator's `enumPropertyNaming` is set to `camelCase`.
    >
    >```yaml
    >    GradleConfigurationCacheResult:
    >      type: object
    >      description: The configuration cache result of a Gradle build.
    >      required:
    >        - outcome
    >      properties:
    >        outcome:
    >          type: string
    >          enum:
    >            - HIT
    >            - MISS
    >            - FAILED
    >          description: |
    >            The outcome of the configuration cache operation:
    >              * `HIT` - There was a configuration cache hit.
    >              * `MISS` - There was a configuration cache miss.
    > * `FAILED` - There was a configuration cache related failure.
    >```
    >
    >The enum casing found in the new spec is inconsistent with previous
    enums, like `TestOutcome`:
    >
    >```yaml
    >    TestOutcome:
    >      type: string
    >      enum:
    >        - passed
    >        - failed
    >        - skipped
    >        - flaky
    >        - notSelected
    >```
    >
    >The issue is surfaced due to the spec's inconsistency, but the cause is
    OpenAPI Generator's `enumPropertyNaming` implementation. The actual
    [`enumPropertyNaming`
    options](https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/kotlin.md)
    implementation will only convert the first char in some cases (see
    [`CamelizeOptions`](https://github.com/OpenAPITools/openapi-generator/blob/2bc0e5f7457615f175ba936a0093f8fc5f7ff1d2/modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/CamelizeOption.java))
    gabrielfeo authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9904850 View commit details
    Browse the repository at this point in the history
  4. Update Kotlin/Jupyter to v0.12.0-285 (#289)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8f6dc8a View commit details
    Browse the repository at this point in the history
  5. Refactor generated API post-processing (#291)

    Reduce code duplication after #288. Also add `.kotlin` to .gitignore, a
    new compiler-internal dir from K2.
    gabrielfeo authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c102b74 View commit details
    Browse the repository at this point in the history
  6. Update dependency org.openapitools:openapi-generator-gradle-plugin to…

    … v7.8.0 (#290)
    
    ###
    [`v7.8.0`](https://redirect.github.com/OpenAPITools/openapi-generator/releases/tag/v7.8.0):
    released
    
    v7.8.0 stable release comes with ~150 enhancements, bug fixes. Once
    again thank you for all the awesome contributions from the community.
    
    This release comes with [2 breaking changes (with
    fallback)](https://redirect.github.com/OpenAPITools/openapi-generator/pulls?q=is%3Apr+milestone%3A7.8.0+is%3Aclosed+label%3A%22Breaking+change+%28with+fallback%29%22)
    listed below.
    
    Below are the highlights of the changes. For a full list of changes,
    please refer to the ["Pull
    Request"](https://redirect.github.com/OpenAPITools/openapi-generator/pulls?q=is%3Amerged+is%3Apr+milestone%3A7.8.0+)
    tab.
    
    #### General
    
    - Added support for openapi-normalizer in the online version
    [#&#8203;19336](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19336)
    - processing schema name is added to the list with names checked at
    recursing processing
    [#&#8203;19221](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19221)
    - Fix mistype in InlineModelResolver leads to autogenerated class name
    instead of specified by title
    [#&#8203;19173](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19173)
    - Speed up docker re-builds using mvn dependency:go-offline
    [#&#8203;19078](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19078)
    
    #### C\#
    
    - \[csharp]\[generichost] Changed default sorting of samples
    [#&#8203;19335](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19335)
    - \[csharp]\[generichost] Support response ranges
    [#&#8203;19256](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19256)
    - \[csharp] Use global keyword
    [#&#8203;19257](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19257)
    - \[csharp] Add scope for oauth2
    [#&#8203;19234](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19234)
    - \[csharp] fix Task.Result directly blocks thread
    [#&#8203;19231](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19231)
    - \[ASPNETCORE] Fix having two "?" when not required and nullable = true
    [#&#8203;19062](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19062)
    - Support net8 in aspnetcore
    [#&#8203;19051](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19051)
    - \[csharp] Change sorting default `Breaking change (with fallback)`
    [#&#8203;1894](https://redirect.github.com/OpenAPITools/openapi-generator/issues/1894)
    
    #### C++
    
    - \[C++]\[Pistache] Fix 'unused-parameter' warning on Helpers.h file
    [#&#8203;19315](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19315)
    - \[C++]\[Pistache] Add error handlers overload taking the response
    object
    [#&#8203;19314](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19314)
    - \[cpp-qt] Add option for download progress, add test
    [#&#8203;19297](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19297)
    
    #### Dart
    
    - fix invalid syntax in gitignore
    [#&#8203;19341](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19341)
    - \[dart-dio] fix JsonObject missing on a generated code
    [#&#8203;19130](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19130)
    
    #### Elixir
    
    - \[Elixir] allow custom packageVersion
    [#&#8203;19151](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19151)
    
    #### Go
    
    - Better handling of backtick in pattern
    [#&#8203;19358](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19358)
    - \[Go] Set Default Values for Required Variables when a default is
    defined
    [#&#8203;19232](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19232)
    
    #### Haskell
    
    - Add bytestring package to dependencies of generated haskell code
    [#&#8203;19101](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19101)
    
    #### Java
    
    - \[JAVA] use query parameter apikey if present
    [#&#8203;19334](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19334)
    - \[JAVA] okhttp-gson client codegen ambiguous references for a
    component schema "Type"
    [#&#8203;19328](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19328)
    - Minor change to Helidon version handling allowing snapshot versions
    [#&#8203;19320](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19320)
    - \[Java] Update ApiClient.mustache for retrofit2 + rxJava3
    [#&#8203;19266](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19266)
    - \[JAVA-CAMEL] revert broken xml change
    [#&#8203;19259](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19259)
    - Support Helidon SE 4 generation (clients and servers)
    [#&#8203;19150](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19150)
    - \[okhttp-gson] migrate to jakarta.ws.rs
    [#&#8203;19113](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19113)
    - Remove thread unsafe statusCode and responseHeaders instance variables
    from apache http ApiClient
    [#&#8203;19054](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19054)
    
    #### Julia
    
    - \[julia] Add support for style, explode in query params
    [#&#8203;19238](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19238)
    
    #### k6
    
    - \[k6] Add authentication variables in headers and cookies
    [#&#8203;19060](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19060)
    
    #### Kotlin
    
    - \[kotlin-client]\[jackson] Add missing
    [@&#8203;JsonEnumDefaultValue](https://redirect.github.com/JsonEnumDefaultValue)
    annotation to top-level enums
    [#&#8203;19380](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19380)
    - \[bugfix]\[kotlin-wiremock] fix problems with range responses
    [#&#8203;19309](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19309)
    - \[Kotlin] Update formParams.mustache to have List of
    MultipartBody.Part
    [#&#8203;19287](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19287)
    - \[Kotlin]\[Spring] fix flag appendRequestToHandler with
    delegatePattern
    [#&#8203;19206](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19206)
    - adds support for x-pattern-message in kotlin-spring generator
    [#&#8203;19134](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19134)
    
    #### PHP
    
    - \[BUG] PHP Client - ObjectSerializer::buildQuery flattens array params
    resulting invalid URL params (param=a\&param=b vs
    param\[]=a\&param\[]=b)
    [#&#8203;19236](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19236)
    - php: Fix typedoc comment for headers in ApiException
    [#&#8203;19217](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19217)
    - feat(php-nextgen-client): add support for streaming
    [#&#8203;19192](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19192)
    
    #### PowerShell
    
    - \[PowerShell] Fix missing Content-Type header on a 204 response
    [#&#8203;19340](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19340)
    - \[PowerShell] Fix response type on deserialization
    [#&#8203;19331](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19331)
    - \[PowerShell]\[Bug] Fix issue
    [#&#8203;18428](https://redirect.github.com/OpenAPITools/openapi-generator/issues/18428)
    - \[System.IO.FileInfo] object used in multipart/form-data submission
    does not support relative paths
    [#&#8203;19269](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19269)
    - \[PowerShell] Support ApiKeyPrefix
    [#&#8203;19133](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19133)
    
    #### Python
    
    - python-asyncio: update retry factors for actual exponential retries
    19337
    - \[Python] fix object arrays giving mypy error "Incompatible types in
    assignment" in to_dict()
    [#&#8203;19223](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19223)
    - Adding decimal support for python client generation
    [#&#8203;19203](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19203)
    - \[python-fastapi] Fix api endpoint template
    [#&#8203;19139](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19139)
    
    #### Ruby
    
    - \[Ruby] Fix Content-Transfer-Encoding binary unpacking
    [#&#8203;19132](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19132)
    - \[Ruby] Allow Overriding Accept Header
    [#&#8203;19106](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19106)
    
    ### Rust
    
    - Make the rust hyper client Send so it can be used in rust threads more
    easily
    [#&#8203;19375](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19375)
    - \[Rust Server] Allow configuration of multipart/form attachment size
    limit
    [#&#8203;19371](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19371)
    - \[Rust Server] Sort operations so that the ones with fewest params
    come first
    [#&#8203;19368](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19368)
    - \[Rust Server] Improve RFC 13341 compliance for multipart/related
    [#&#8203;19355](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19355)
    - Rust: Support Integer enums using Serde_repr
    [#&#8203;19199](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19199)
    - Upgrade rust-hyper to use hyper 1.0 `Breaking change (with fallback)`
    [#&#8203;19115](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19115)
    
    #### Swift
    
    - \[swift5]Add array validation rule
    [#&#8203;19242](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19242)
    
    #### TypeScript
    
    - feat(typescript-angular): add support for Angular V18.1
    [#&#8203;19228](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19228)
    - \[typescript-fetch] Fix code generation for oneOf cases without
    discriminator
    [#&#8203;19219](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19219)
    - \[FIX]\[typescript-fetch] Fix duplicate imports for models with a
    discriminator
    [#&#8203;19195](https://redirect.github.com/OpenAPITools/openapi-generator/issues/19195)
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0c6467c View commit details
    Browse the repository at this point in the history
  7. Add binary compatibility validator plugin (#292)

    Add binary compatibility validator plugin and dump 2024.1.1 API. The
    goal of committing the 2024.1.1 API file now (in a branch that's already
    well past it, with many API changes) is to preserve a clear view of this
    release's API changes in git log.
    
    API dumped from the 2024.1.1 tag with
    b1b7ae4 cherry-picked on top. File not
    yet validated on CI.
    gabrielfeo authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8470ba8 View commit details
    Browse the repository at this point in the history
  8. Prepare for next release (#293)

    - Bump library version
    - Dump latest API (diff is from 2024.1.1 to current code, see #292)
    - Add apiCheck to PR workflow
    gabrielfeo authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    70a4410 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8c7f5d1 View commit details
    Browse the repository at this point in the history
Loading