Wasm support #6
Wasm support #6
Conversation
terrakok
commented
Aug 13, 2024
terrakok
commented
| toolchain { | ||
| languageVersion.set(JavaLanguageVersion.of("17")) | ||
| } |
There was a problem hiding this comment.
Even if toolchain usage is recommended by Google and Gradle, the developer community doesn't. Especially Jake Wharton in this post so I would like to keep the old way. Or maybe you can explain me why you suggest it? Thanks!
There was a problem hiding this comment.
I set the toolchain to configure both java and kotlin compilations here. Without the toolchain the import fails with
Execution failed for task ':build-logic:convention:compileKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileJava' (17) and 'compileKotlin' (21).
because your config configures only java's compilation
There was a problem hiding this comment.
I know Jake's post but, I guess, sometimes he is too radical. Convenient and easiness are more valuable than abstract things. Have you met problems with a compilation with java 17? Why do think it is worse than a compilation with higher javas?
There was a problem hiding this comment.
you can reproduce it: IDE -> Preferences -> Kotlin Compiler -> Change Target JVM version -> set non-17 java (which is your default as I understand)
There was a problem hiding this comment.
Ok, sorry for the late response. Let me try things around, I always had solvable problems with Java 17 so far and actually I've never fully tested toolchains, also because Jake's post kinda frightened me ngl!
There was a problem hiding this comment.
I realised you did the modification on the build logic module. I thought it was on the library, sorry about that, using the toolchain on build sources doesn't bother me at all.
Actually, regarding the import issue you had, I got that fail once but I wasn't able to reproduce it! So that's the correct way to do it, thank you for correcting it!
it is not stable for the final applications but it is ready for libraries and frameworks. Everyone will make decision by their own use or not the wasm target but your library is ready already 👍 |
