Allow for multiple env-files #616
Conversation
| assert client_config.docker_compose_cmd[index + 1] == env_file | ||
|
|
||
|
|
||
| def test_compose_env_files_and_env_file(): |
There was a problem hiding this comment.
The tests are good, keep them :) I'd also like a test which actually runs the docker compose command and checks that the env files are loaded correctly. For example with docker.compose.config(). If for example, you made a typo in --env-file in the unit test and the main implementation, your tests can't currently detect it. Running the true command in test would detect such an error.
There was a problem hiding this comment.
Added some more tests now that actually run the command by using the equivalent of docker compose run. Some temporary env-files are made, and the containers are then inspected to verify that the actual environment variables set in the container are as expected. Pretty verbose, and I am sure it can be done simpler, but let me know if this is what you wanted :)
There was a problem hiding this comment.
Rather than running the containers, using https://gabrieldemarmiesse.github.io/python-on-whales/sub-commands/compose/#python_on_whales.components.compose.cli_wrapper.ComposeCLI.config would have made the test simpler no? just switch docker.compose.run for docker.compose.config()
There was a problem hiding this comment.
Aha, yeah that is a lot simpler. Updated now :)
gabrieldemarmiesse
merged commit 69b2ac3
into
gabrieldemarmiesse:master
Sorry for the mess with multiple PRs, not used to making PR's from forks :)
Closes #553
Keeps backwards compatibility with the compose_env_file parameter, but advises the user to use the new compose_env_files parameter instead. If both parameters are given, the compose_env_files will take presedence.
Added tests to verify behavior