feat(service): Add docker service ls --filter option #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuentes73
force-pushed
the
add-service-filter
branch
2 times, most recently
from
c9c5e1e
to
c54749c
Compare
gabrieldemarmiesse
requested changes
Mar 9, 2024
| @@ -353,13 +353,14 @@ def logs( | |||
| else: | |||
| return "".join(x[1].decode() for x in iterator) | |||
|
|
|||
| def list(self) -> List[Service]: | |||
| def list(self, filters: Dict[str, str] = {}) -> List[Service]: | |||
There was a problem hiding this comment.
Can you update the docstring with an example? Thanks!
| @@ -45,6 +45,25 @@ def test_get_list_of_services(docker_client: DockerClient): | |||
| assert [my_service] == list_of_services | |||
|
|
|||
|
|
|||
| @pytest.mark.usefixtures("swarm_mode") | |||
| def test_filters(docker_client: DockerClient): | |||
There was a problem hiding this comment.
Can you try to filter with a label that does not exist and verify that no services are returned? That would ensure that the function is correctly removing services from the result.
fuentes73
force-pushed
the
add-service-filter
branch
from
c54749c
to
6f65fb6
Compare
|
@gabrieldemarmiesse thanks for your quick feedback. Done, let me know if everything is ok. |
auto-merge was automatically disabled
March 9, 2024 09:53
Head branch was pushed to by a user without write access
fuentes73
force-pushed
the
add-service-filter
branch
from
6f65fb6
to
9ffdd5e
Compare
|
@gabrieldemarmiesse i've had to rebase because it wasn't up to date. Can you enable auto-merge again? |
gabrieldemarmiesse
merged commit e45f0cd
into
gabrieldemarmiesse:master
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker service ls --filter option