Skip to content

Commit d5f8be8

Browse files
stephenjwinnstephenjwinn
committed
be more stringent. don't just assert not empty. make sure it equals what we want
1 parent a3a9a7e commit d5f8be8

File tree

1 file changed

+40
-37
lines changed

1 file changed

+40
-37
lines changed

‎tests/Ups/Tests/Entity/InternationalFormsTest.php

Lines changed: 40 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -31,32 +31,35 @@ public function setUp()
3131
'Code' => ShipperFiled::SF_ITN,
3232
'Description' => 'Sup Dog',
3333
'PreDepartureITNNumber' => '12345',
34-
'ExemptionLegend' => '12345'
34+
'ExemptionLegend' => '67890'
3535
))
3636
)
3737
)));
3838
}
3939

4040
public function testConstruct()
4141
{
42+
$eei = $this->data->EEIFilingOption;
4243
$forms = new InternationalForms($this->data);
43-
$this->assertNotEmpty($forms->getEEIFilingOption());
44-
$this->assertNotEmpty($forms->getEEIFilingOption()->getCode());
45-
$this->assertNotEmpty($forms->getEEIFilingOption()->getEmailAddress());
46-
$this->assertNotEmpty($forms->getEEIFilingOption()->getDescription());
47-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled());
48-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled()->getPOA());
49-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getCode());
50-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getDescription());
51-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled());
52-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getCode());
53-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getDescription());
54-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getPreDepartureITNNumber());
55-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getExemptionLegend());
44+
45+
$this->assertEquals($forms->getEEIFilingOption(), new EEIFilingOption($eei));
46+
$this->assertEquals($forms->getEEIFilingOption()->getCode(), $eei->Code);
47+
$this->assertEquals($forms->getEEIFilingOption()->getEmailAddress(), $eei->EmailAddress);
48+
$this->assertEquals($forms->getEEIFilingOption()->getDescription(), $eei->Description);
49+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled(), new UPSFiled($eei->UPSFiled));
50+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled()->getPOA(), new POA($eei->UPSFiled->POA));
51+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getCode(), $eei->UPSFiled->POA->Code);
52+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getDescription(), $eei->UPSFiled->POA->Description);
53+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled(), new ShipperFiled($eei->ShipperFiled));
54+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getCode(), $eei->ShipperFiled->Code);
55+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getDescription(), $eei->ShipperFiled->Description);
56+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getPreDepartureITNNumber(), $eei->ShipperFiled->PreDepartureITNNumber);
57+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getExemptionLegend(), $eei->ShipperFiled->ExemptionLegend);
5658
}
5759

5860
public function testGettersAndSetters()
5961
{
62+
$eei = $this->data->EEIFilingOption;
6063
$forms = new InternationalForms();
6164

6265
$this->assertEmpty($forms->getEEIFilingOption());
@@ -83,29 +86,29 @@ public function testGettersAndSetters()
8386
$this->assertEmpty($forms->getEEIFilingOption()->getShipperFiled()->getPreDepartureITNNumber());
8487
$this->assertEmpty($forms->getEEIFilingOption()->getShipperFiled()->getExemptionLegend());
8588

86-
$forms->getEEIFilingOption()->setCode(EEIFilingOption::FO_UPS);
87-
$forms->getEEIFilingOption()->setDescription('Hello World');
88-
$forms->getEEIFilingOption()->setEmailAddress('test@test.com');
89-
$forms->getEEIFilingOption()->getUPSFiled()->getPOA()->setCode(POA::POA_BLANKET);
90-
$forms->getEEIFilingOption()->getUPSFiled()->getPOA()->setDescription('Goodbye World');
91-
$forms->getEEIFilingOption()->getShipperFiled()->setCode(ShipperFiled::SF_EXEMPTION_LEGEND);
92-
$forms->getEEIFilingOption()->getShipperFiled()->setDescription('Sup Dog');
93-
$forms->getEEIFilingOption()->getShipperFiled()->setPreDepartureITNNumber('12345');
94-
$forms->getEEIFilingOption()->getShipperFiled()->setExemptionLegend('12345');
95-
96-
$this->assertNotEmpty($forms->getEEIFilingOption());
97-
$this->assertNotEmpty($forms->getEEIFilingOption()->getCode());
98-
$this->assertNotEmpty($forms->getEEIFilingOption()->getEmailAddress());
99-
$this->assertNotEmpty($forms->getEEIFilingOption()->getDescription());
100-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled());
101-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled()->getPOA());
102-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getCode());
103-
$this->assertNotEmpty($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getDescription());
104-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled());
105-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getCode());
106-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getDescription());
107-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getPreDepartureITNNumber());
108-
$this->assertNotEmpty($forms->getEEIFilingOption()->getShipperFiled()->getExemptionLegend());
89+
$forms->getEEIFilingOption()->setCode($eei->Code);
90+
$forms->getEEIFilingOption()->setDescription($eei->Description);
91+
$forms->getEEIFilingOption()->setEmailAddress($eei->EmailAddress);
92+
$forms->getEEIFilingOption()->getUPSFiled()->getPOA()->setCode($eei->UPSFiled->POA->Code);
93+
$forms->getEEIFilingOption()->getUPSFiled()->getPOA()->setDescription($eei->UPSFiled->POA->Description);
94+
$forms->getEEIFilingOption()->getShipperFiled()->setCode($eei->ShipperFiled->Code);
95+
$forms->getEEIFilingOption()->getShipperFiled()->setDescription($eei->ShipperFiled->Description);
96+
$forms->getEEIFilingOption()->getShipperFiled()->setPreDepartureITNNumber($eei->ShipperFiled->PreDepartureITNNumber);
97+
$forms->getEEIFilingOption()->getShipperFiled()->setExemptionLegend($eei->ShipperFiled->ExemptionLegend);
98+
99+
$this->assertEquals($forms->getEEIFilingOption(), new EEIFilingOption($eei));
100+
$this->assertEquals($forms->getEEIFilingOption()->getCode(), $eei->Code);
101+
$this->assertEquals($forms->getEEIFilingOption()->getEmailAddress(), $eei->EmailAddress);
102+
$this->assertEquals($forms->getEEIFilingOption()->getDescription(), $eei->Description);
103+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled(), new UPSFiled($eei->UPSFiled));
104+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled()->getPOA(), new POA($eei->UPSFiled->POA));
105+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getCode(), $eei->UPSFiled->POA->Code);
106+
$this->assertEquals($forms->getEEIFilingOption()->getUPSFiled()->getPOA()->getDescription(), $eei->UPSFiled->POA->Description);
107+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled(), new ShipperFiled($eei->ShipperFiled));
108+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getCode(), $eei->ShipperFiled->Code);
109+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getDescription(), $eei->ShipperFiled->Description);
110+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getPreDepartureITNNumber(), $eei->ShipperFiled->PreDepartureITNNumber);
111+
$this->assertEquals($forms->getEEIFilingOption()->getShipperFiled()->getExemptionLegend(), $eei->ShipperFiled->ExemptionLegend);
109112
}
110113

111114
public function testValidXML()

0 commit comments

Comments
 (0)