Skip to content
This repository was archived by the owner on Jul 11, 2024. It is now read-only.

Feature/android v2 #47

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Feature/android v2 #47

merged 2 commits into from
Sep 15, 2021

Conversation

atrope
Copy link
Contributor

@atrope atrope commented Aug 13, 2021

Changing from V1 RegisterWith to V2 Embed.

Refers to #46

@yusriltakeuchi
Copy link

Can i use your PR in my flutter project? if the author has not done a merge request

@atrope
Copy link
Contributor Author

atrope commented Aug 17, 2021

@yusriltakeuchi Sure! just add to your pubspec:

  flutter_app_badger:
    git:
      url: https://github.com/SuaMusica/flutter_app_badger.git
      ref: feature/androidV2

Always check this PR because you should always use versions from pubspec(when you can of course) :)

Copy link

@SebghatYusuf SebghatYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will fix the issue

@dustin-graham
Copy link

@g123k , Can we get this fix merged and released?

@JErazo7
Copy link

JErazo7 commented Sep 14, 2021

We need this ASAP, please

@wenboLee
Copy link

me too

@g123k g123k merged commit 5db5453 into g123k:master Sep 15, 2021
@atrope
Copy link
Contributor Author

atrope commented Oct 4, 2021

@ghenry you should remove ALL referentes tô registerwith. This is generated automattically

@ghenry
Copy link

ghenry commented Oct 4, 2021

But I call this plugin with FCM and it has always been needed. When did that change?

@atrope
Copy link
Contributor Author

atrope commented Oct 4, 2021

@ghenry with Android V2 Embeded those plugins should be registered automatically

@ghenry
Copy link

ghenry commented Oct 4, 2021 via email

@atrope
Copy link
Contributor Author

atrope commented Oct 4, 2021

@ghenry it is not needed if the plugin is using V2 Embeded.

@ghenry
Copy link

ghenry commented Oct 4, 2021

Hmm.. Not sure you're correct there.

@atrope
Copy link
Contributor Author

atrope commented Oct 4, 2021

@ghenry
Copy link

ghenry commented Oct 4, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants