Skip to content

Conversation

@schnoddelbotz
Copy link
Contributor

As discussed in issue #72

  • Don't panic if ExitCode() is called before RunLocalShell() - return -1 like os.exec would before wait()
  • Add a minimal test for the above
  • Add windows support
  • Update documentation/README with example usage

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation thanks. Just a note about the new API return info.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, great change :)

@andydotxyz andydotxyz merged commit 57e445f into fyne-io:master Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants